MicrostockGroup

Microstock Photography Forum - General => Symbiostock => Symbiostock - Development Area => Topic started by: djpadavona on July 28, 2013, 10:55

Title: Pages - Browsing Bug
Post by: djpadavona on July 28, 2013, 10:55
I've noticed for the last few versions of Symbiostock that there is a bug when browsing through pages of Categories and Search Results. Images on page 1 of the results often show up again on pages 2, 3, etc, while some images simply get skipped.

I may be wrong, but it appears to me that a random number is being applied to the results to give customers a slightly different sort each time they search. That's good. But I think the randomness is being applied on each page, rather than created once per visit. This would cause some images to show up multiple times as the random number changes its search/category position, and others to be skipped.

If this is the case, my suggestion is to apply the random seeding at the initial category or search query, and not per page. If this is too difficult, maybe drop it altogether? Either way, it looks bad to see the same images popping up on multiple pages.
Title: Re: Pages - Browsing Bug
Post by: stockphoto-images.com on July 28, 2013, 11:15
I noticed that as well although I don't know exactly when this "bug" started.

If I have more than 20 search results for a certain keyword and I go to page 2, I will see some images from the first search results page again.
Might be confusing for buyers.
Title: Re: Pages - Browsing Bug
Post by: djpadavona on July 28, 2013, 11:19
If I am not mistaken, I believe it arrived at the time of the Image Rank and Rating implementation (2.4.8 or 2.4.9?). I think the randomness is a good idea if it can be made to work once per query. But if not, just kill it. I agree it is confusing for buyers.
Title: Re: Pages - Browsing Bug
Post by: ShazamImages on July 28, 2013, 12:10
I have also noticed this, but haven't had time to look into it.
Title: Re: Pages - Browsing Bug
Post by: Ron on July 29, 2013, 02:52
Agree with Dan, I said it from the beginning, I dont like how the images are displayed randomly. We need to have a newest and a random filter if possible.

Someone posted a code how to change it to newest again, but I cant find that code here now. I really want to have newest search back as the random display is not working for me.
Title: Re: Pages - Browsing Bug
Post by: Leo Blanchette on July 29, 2013, 03:11
This is new for me! I never noticed randomness. I'm making improvements to the base theme so thanks for mentioning.
Title: Re: Pages - Browsing Bug
Post by: THP Creative on August 22, 2013, 01:52
I was showing someone my site and noticed the same bug. It is constantly there, no matter what browser or category I am looking at.

Hopefully this one can get ironed out as it was really off-putting to browse through pages and see the same images repeated.
Title: Re: Pages - Browsing Bug
Post by: Ron on August 22, 2013, 02:33
I implemented the code change, and my images are displayed in chronological order again, really like that.

http://semmickphoto.com/image/ (http://semmickphoto.com/image/) this way your series stay together as well
Title: Re: Pages - Browsing Bug
Post by: marthamarks on August 22, 2013, 07:15
I implemented the code change, and my images are displayed in chronological order again, really like that.

[url]http://semmickphoto.com/image/[/url] ([url]http://semmickphoto.com/image/[/url]) this way your series stay together as well


Ron, what is "the code change" that you implemented? Where did you get it?

I don't see it mentioned in this thread. Is it mentioned somewhere else?

Thanks!
Title: Re: Pages - Browsing Bug
Post by: Ron on August 22, 2013, 07:59
I implemented the code change, and my images are displayed in chronological order again, really like that.

[url]http://semmickphoto.com/image/[/url] ([url]http://semmickphoto.com/image/[/url]) this way your series stay together as well


Ron, what is "the code change" that you implemented? Where did you get it?

I don't see it mentioned in this thread. Is it mentioned somewhere else?

Thanks!


http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801 (http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801)
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 22, 2013, 08:05
I implemented the code change, and my images are displayed in chronological order again, really like that.

[url]http://semmickphoto.com/image/[/url] ([url]http://semmickphoto.com/image/[/url]) this way your series stay together as well


Ron, what is "the code change" that you implemented? Where did you get it?

I don't see it mentioned in this thread. Is it mentioned somewhere else?

Thanks!


[url]http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801[/url] ([url]http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801[/url])



Thanks for posting, i needed that too.
Title: Re: Pages - Browsing Bug
Post by: marthamarks on August 22, 2013, 08:42
I implemented the code change, and my images are displayed in chronological order again, really like that.

[url]http://semmickphoto.com/image/[/url] ([url]http://semmickphoto.com/image/[/url]) this way your series stay together as well


Ron, what is "the code change" that you implemented? Where did you get it?

I don't see it mentioned in this thread. Is it mentioned somewhere else?

Thanks!


[url]http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801[/url] ([url]http://www.microstockgroup.com/symbiostock-technical-support/2-5-5-still-some-unanswered-questions/msg335801/#msg335801[/url])


Thanks for that, Ron. It helps!
Title: Re: Pages - Browsing Bug
Post by: Anita Potter on August 22, 2013, 09:16
Is this just related to 2.5.5 because I don't think I see it in 2.6.
Title: Re: Pages - Browsing Bug
Post by: ShazamImages on August 22, 2013, 09:22
2.6.

2.6  ???

I thought that the latest public version was 2.5.6
Title: Re: Pages - Browsing Bug
Post by: Anita Potter on August 22, 2013, 09:45
My bad.  I keep getting my numbers mixed up WP 3.6 and SY 2.5.6.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 22, 2013, 09:54
2.6.

2.6  ???

I thought that the latest public version was 2.5.6

So is that code only for 2.5.6 or is it for 2.5.5?
Title: Re: Pages - Browsing Bug
Post by: marthamarks on August 22, 2013, 10:00
2.6.

2.6  ???

I thought that the latest public version was 2.5.6

So is that code only for 2.5.6 or is it for 2.5.5?

I was wondering that too. I've upgraded to 2.5.6 and also to WP 3.6... all without incident.
Title: Re: Pages - Browsing Bug
Post by: THP Creative on August 24, 2013, 03:23
So am I right in thinking this code actually doesn't 'fix' the bug as such, but just removes the image ranking system from showing up in the sort order?
Title: Re: Pages - Browsing Bug
Post by: sandorgora on August 24, 2013, 14:16
just noticed it now after reading this post;
i have 2.5.6 and also images were random;
now fixed it with the solution as mentioned.
kind regards, Sándor Góra
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 06:49
I just upgraded to what I think is 2.5.6 (link posted by redneck in other thread) but the Details tab in Theme says 2.5.5. So not sure if I have 2.5.5 or 2.5.6. Is there another way to tell?

But I added the code from Ron's link to network-manager.php and the sort order remains ASC not DESC.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 06:55
Also scrolling down a little farther, found this (see screenshot).

Shouldnt line 1787 also be messages not massages?  :o
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 09:09
So is that code only for 2.5.6 or is it for 2.5.5?

I have added the code in 2.5.5, and it is not changing my sort order. I am trying to upgrade to 2.5.6 and see if it works there.
Title: Re: Pages - Browsing Bug
Post by: Ron on August 25, 2013, 09:30
I have 2.5.5 and it works fine
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 09:38
I have 2.5.5 and it works fine

Do I need to change anything in the dashboard or SY settings in the dashboard? Hmm, wonder why it's not working.
Title: Re: Pages - Browsing Bug
Post by: Ron on August 25, 2013, 09:44
I Just edited the code and that was it. I used the blue host file editor to do it. I did use the original code and didnt change anything from DESC to ASC, all my images are GREEN and priority 2.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 09:52
I Just edited the code and that was it. I used the blue host file editor to do it. I did use the original code and didnt change anything from DESC to ASC, all my images are GREEN and priority 2.

Is this the code you used? (copied from your link)

Code: [Select]
edit network-manager.php (in symbiostock/inc/classes/network-manager).

Go to lines 1477-1500. There will be three times 'order'     => 'ASC', change all to 'order'     => 'DESC'.

Then go to comment
//temporary function until everyone has toggled their theme   and is equal to or above 2.4.9

and below change
      if(   $image_rank_update == true ){         
to
      if(   $image_rank_update == false ){         

now you should have old sort order.

If yes, you did change ASC to DESC.

But maybe I misunderstood...I thought that code would ignore the whole GREEN-YELLOW-RED thing and change the sort order back to the images showing by first uploaded date first.
Title: Re: Pages - Browsing Bug
Post by: Ron on August 25, 2013, 10:32
Ow sorry, yes, I took that code and made the changes, but I didnt do anything else.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 10:36
Ow sorry, yes, I took that code and made the changes, but I didnt do anything else.

OK.

I also updated to 2.5.6, reuploaded network-manager.php with the changed code, and it still didn't change the sort order.  :(
Title: Re: Pages - Browsing Bug
Post by: Ron on August 25, 2013, 10:40
I am on 2.5.5
Title: Re: Pages - Browsing Bug
Post by: ShazamImages on August 25, 2013, 11:14
...I added the code from Ron's link to network-manager.php and the sort order remains ASC not DESC.

I just did a search on your site (for "food") and the images look like they are in DESC order.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 12:03
...I added the code from Ron's link to network-manager.php and the sort order remains ASC not DESC.

I just did a search on your site (for "food") and the images look like they are in DESC order.


But the order looks the same as when I had the code that said ASC.

So just to be clear, if I want my images to show this way: images that I uploaded first (older date) to show up on the first page, and the images that I just uploaded recently to show on the last page (newer date), which order should they appear in, ASC or DESC?

As I said, it didn't seem to matter whether the code said ASC or DESC, the images show in the order that I see now, which is the images that I uploaded a few days, with newer date, show on page one, and images I uploaded first, which were my best images, show on the last page (older date). Screenshot below:
Title: Re: Pages - Browsing Bug
Post by: ShazamImages on August 25, 2013, 12:12
So just to be clear, if I want my images to show this way: images that I uploaded first (older date) to show up on the first page, and the images that I just uploaded recently to show on the last page (newer date), which order should they appear in, ASC or DESC?

To order dates from oldest to newest, you would use ASC (ascending) order.

I'm just not sure what field the search is ordering on.
Title: Re: Pages - Browsing Bug
Post by: ShazamImages on August 25, 2013, 12:24
So just to be clear, if I want my images to show this way: images that I uploaded first (older date) to show up on the first page, and the images that I just uploaded recently to show on the last page (newer date), which order should they appear in, ASC or DESC?

To order dates from oldest to newest, you would use ASC (ascending) order.

I'm just not sure what field the search is ordering on.

I just checked at it seems to be ordering search results on the date (if you set $image_rank_update == false as suggested above), so if you set the order to ASC then it should show your images from oldest to newest.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 12:29
So just to be clear, if I want my images to show this way: images that I uploaded first (older date) to show up on the first page, and the images that I just uploaded recently to show on the last page (newer date), which order should they appear in, ASC or DESC?

To order dates from oldest to newest, you would use ASC (ascending) order.

I'm just not sure what field the search is ordering on.

I just checked at it seems to be ordering search results on the date (if you set $image_rank_update == false as suggested above), so if you set the order to ASC then it should show your images from oldest to newest.

OK let me try that.
Title: Re: Pages - Browsing Bug
Post by: cathyslife on August 25, 2013, 12:36
I just checked at it seems to be ordering search results on the date (if you set $image_rank_update == false as suggested above), so if you set the order to ASC then it should show your images from oldest to newest.

Yes, that is correct! Thanks for figuring that out.

So if you want your first-uploaded images (oldest date) to show FIRST in the sort/search, do this:

Code: [Select]
edit network-manager.php (in symbiostock/inc/classes/network-manager).

Go to lines 1504, below the line that says:
//temporary function until everyone has toggled their theme   and is equal to or above 2.4.9

change that line
      if(   $image_rank_update == true ){         
to
      if(   $image_rank_update == false ){